QUICK: 2]Material Valuation

Report: Material Valuation (Validation and Fixes.....)

Issue 1: Material Decription  [Naming issue: check the main source] [Impact: LOW]

 

Issue 2:  [Impact: MEDIUM]

Joins=>

Join name: A]Product to Sales Org  [one line need to be added]

"one product_id have multiple sales org"

# Code:

New_updated Code for Product to Sales Org: 

SALES_ORG_DISTINCT AS (

        SELECT DISTINCT 

            product_id,

            sales_org_code, # CT_XYLEM_19_03

            Item_category_group_from_material_master,

            Delivering_Plant_Own_or_External 

      FROM {gold_catalog_name}.master_data.product_sales_organization

# Comment: New Line need to be added in the join.

B] Product_Plant to Inventory  [Impact: Low]

# LOC: 27

# Code:

CT_XYLEM=>

     In SAP Inventory comes from MARD (Storage Location / Inventory table),

     but in our code we are using gold.inventory_stock_levels.inventory_stock_levels

     This is a derived gold table, not raw SAP

# Comment:

     Final=> code is Technically correct But depends on another table (gold)

Issue 3: 

Filters

1] Historical Data Filter (3 Years) [Impact: HIGH]

# LOC: 84

# Code:

# CT_XYLEM_19_03(Added Filter: Historical Data Filter of 3 years)

        AND COALESCE(p.creation_date, p.date_of_last_change)

        >= DATE_SUB(CURRENT_DATE(), INTERVAL 3 YEAR)

# Comment: 

Added Filter: Historical Data Filter of 3 year

2]Deletion Flags (LVORM) [Impact: HIGH]

# LOC: 

# Code:

 # CT_XYLEM_19_03(Added Filter:Deletion Flag(LVORM))

        AND (p.lvorm IS NULL OR p.lvorm = ' ')

        AND (pp.lvorm IS NULL OR pp.lvorm = ' ')

#Comment: Added Filter in Code for Deletion 

>> Data Quality Checks

Issue 4: Data Quality Checks

1] Currency Conversion  [Impact: Low]

Solution=>

If Business Confirms,

 All data is already in single currency,

Then:

Update FDD:

All monetary values are stored in single currency; TCURR conversion not required

2] Negative Price Validation  [Imact: HIGH]

# Code:

# CT_XYLEM_19_03(Added Quality Check :Negative Price Validation)

        AND pp.moving_average_price >= 0

        AND pp.standard_price >= 0

# Comment: 

3]  Deletion Flag Filtering   [Imact: HIGH]

# Code:

 # CT_XYLEM_19_03(Added Filter:Deletion Flag(LVORM))

        AND (p.lvorm IS NULL OR p.lvorm = ' ')

        AND (pp.lvorm IS NULL OR pp.lvorm = ' ')